cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [cloudstack] anuragaw commented on a change in pull request #3778: Endless settings on templates and instances
Date Sat, 21 Dec 2019 02:49:31 GMT
anuragaw commented on a change in pull request #3778: Endless settings on templates and instances
URL: https://github.com/apache/cloudstack/pull/3778#discussion_r360624658
 
 

 ##########
 File path: ui/scripts/instances.js
 ##########
 @@ -3437,6 +3437,13 @@
 						custom: cloudStack.uiCustom.granularDetails({
                         resourceType: 'UserVm',
 							dataProvider: function(args) {
+                                // no paging for listVirtualMachines details
+                                if (args.page > 1){
+                                    args.response.success({
+                                        data: []
+                                    });
+                                    return;
+                                }
 
 Review comment:
   Isn't this supposed to be inside dataProvider @DaanHoogland ? So should be more right aligned?
   
   ![image](https://user-images.githubusercontent.com/43956255/71301851-6a2e3300-23ca-11ea-9eaa-1f435ec3b363.png)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message