cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <>
Subject [GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3510: [WIP DO NOT MERGE] Allow additional config to vms
Date Fri, 20 Dec 2019 10:50:38 GMT
DaanHoogland commented on a change in pull request #3510: [WIP DO NOT MERGE] Allow additional
config to vms

 File path: plugins/hypervisors/xenserver/src/main/java/org/apache/cloudstack/hypervisor/xenserver/
 @@ -0,0 +1,170 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.hypervisor.xenserver;
+import java.util.HashMap;
+import java.util.Map;
+import com.xensource.xenapi.Connection;
+import com.xensource.xenapi.Types;
+import com.xensource.xenapi.VM;
+import org.apache.log4j.Logger;
+import org.apache.xmlrpc.XmlRpcException;
+public class ExtraConfigurationUtility {
+    private static final Logger LOG = Logger.getLogger(ExtraConfigurationUtility.class);
+    public static void setExtraConfigurationToVm(Connection conn, VM.Record vmr, VM vm, Map<String,
String> extraConfig) {
 Review comment:
   can you factor out (at least the switches) for readability?

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

With regards,
Apache Git Services

View raw message