cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [cloudstack] anuragaw commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router
Date Tue, 17 Dec 2019 09:23:24 GMT
anuragaw commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature
for virtual router
URL: https://github.com/apache/cloudstack/pull/3575#discussion_r358679982
 
 

 ##########
 File path: core/src/main/java/com/cloud/agent/resource/virtualnetwork/facade/AbstractConfigItemFacade.java
 ##########
 @@ -127,7 +127,10 @@ private static String appendUuidToJsonFiles(final String filename) {
         final ConfigItem configFile = new FileConfigItem(VRScripts.CONFIG_PERSIST_LOCATION,
remoteFilename, gson.toJson(configuration));
         cfg.add(configFile);
 
-        final ConfigItem updateCommand = new ScriptConfigItem(VRScripts.UPDATE_CONFIG, remoteFilename);
+        // By default keep files in processed cache on VR
+        final String args = configuration.shouldDeleteFromProcessedCache() ? remoteFilename
+ " false" : remoteFilename;
+
+        final ConfigItem updateCommand = new ScriptConfigItem(VRScripts.UPDATE_CONFIG, args);
 
 Review comment:
   Well not cleaner per say but an option to not save some configs if the flag is set to true.
This saves space on VR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message