cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [cloudstack] anuragaw commented on a change in pull request #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router
Date Tue, 17 Dec 2019 07:18:17 GMT
anuragaw commented on a change in pull request #3350: Get Diagnostics: Download logs and diagnostics
data from SSVM, CPVM, Router
URL: https://github.com/apache/cloudstack/pull/3350#discussion_r358632573
 
 

 ##########
 File path: server/src/main/java/org/apache/cloudstack/diagnostics/DiagnosticsServiceImpl.java
 ##########
 @@ -92,13 +155,13 @@
 
         Map<String, String> detailsMap;
 
-        final Answer answer = agentManager.easySend(hostId, command);
+        Answer answer = agentManager.easySend(hostId, command);
 
-        if (answer != null && (answer instanceof DiagnosticsAnswer)) {
+        if (answer != null) {
             detailsMap = ((DiagnosticsAnswer) answer).getExecutionDetails();
             return detailsMap;
         } else {
-            throw new CloudRuntimeException("Failed to execute diagnostics command on remote
host: " + answer.getDetails());
+            throw new CloudRuntimeException("Failed to execute diagnostics command on remote
host: " + vmInstance.getHostName());
 
 Review comment:
   The command is run on a systemvm (cpvm, ssvm, router), but the message logs the host name.
I've reworded to make it somewhat better.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message