cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router
Date Mon, 16 Dec 2019 12:46:04 GMT
DaanHoogland commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature
for virtual router
URL: https://github.com/apache/cloudstack/pull/3575#discussion_r358203567
 
 

 ##########
 File path: server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
 ##########
 @@ -1692,8 +2157,8 @@ public boolean finalizeCommandsOnStart(final Commands cmds, final VirtualMachine
         return true;
     }
 
-    private void finalizeMonitorServiceOnStrat(final Commands cmds, final VirtualMachineProfile
profile, final DomainRouterVO router, final Provider provider,
-            final long networkId, final Boolean add) {
+    private void finalizeMonitorServiceOnStart(final Commands cmds, final VirtualMachineProfile
profile, final DomainRouterVO router, final Provider provider,
 
 Review comment:
   👍 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message