cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP)
Date Thu, 12 Dec 2019 15:31:07 GMT
DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP)
URL: https://github.com/apache/cloudstack/pull/3748#discussion_r357167383
 
 

 ##########
 File path: server/src/main/java/com/cloud/storage/mount/NfsMountManager.java
 ##########
 @@ -0,0 +1,203 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package com.cloud.storage.mount;
+
+import java.io.BufferedReader;
+import java.io.File;
+import java.io.IOException;
+import java.net.URI;
+import java.net.URISyntaxException;
+import java.nio.file.Files;
+import java.nio.file.Paths;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Random;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ConcurrentMap;
+
+import javax.annotation.PreDestroy;
+
+import org.apache.cloudstack.framework.config.ConfigKey;
+import org.apache.cloudstack.utils.identity.ManagementServerNode;
+import org.apache.log4j.Logger;
+import org.springframework.stereotype.Component;
+
+import com.cloud.storage.StorageLayer;
+import com.cloud.utils.exception.CloudRuntimeException;
+import com.cloud.utils.script.OutputInterpreter;
+import com.cloud.utils.script.Script;
+
+@Component
+public class NfsMountManager implements MountManager {
+    private static final Logger s_logger = Logger.getLogger(NfsMountManager.class);
+
+    private StorageLayer storage;
+    private int timeout;
+    private final Random rand = new Random(System.currentTimeMillis());
+    private final ConcurrentMap<String, String> storageMounts = new ConcurrentHashMap<>();
+
+    public static final ConfigKey<String> MOUNT_PARENT = new ConfigKey<>("Advanced",
String.class,
+            "mount.parent", "/var/cloudstack/mnt",
+            "The mount point on the Management Server for Secondary Storage.",
+            true, ConfigKey.Scope.Global);
+
+    public NfsMountManager(StorageLayer storage, int timeout) {
+        this.storage = storage;
+        this.timeout = timeout;
+    }
+
+    public String getMountPoint(String storageUrl, Integer nfsVersion) {
+        String mountPoint = storageMounts.get(storageUrl);
+        if (mountPoint != null) {
+            return mountPoint;
+        }
+
+        URI uri;
+        try {
+            uri = new URI(storageUrl);
+        } catch (URISyntaxException e) {
+            s_logger.error("Invalid storage URL format ", e);
+            throw new CloudRuntimeException("Unable to create mount point due to invalid
storage URL format " + storageUrl);
+        }
+
+        mountPoint = mount(uri.getHost() + ":" + uri.getPath(), MOUNT_PARENT.value(), nfsVersion);
+        if (mountPoint == null) {
+            s_logger.error("Unable to create mount point for " + storageUrl);
+            throw new CloudRuntimeException("Unable to create mount point for " + storageUrl);
+        }
+
+        storageMounts.putIfAbsent(storageUrl, mountPoint);
+        return mountPoint;
+    }
+
+    private String mount(String path, String parent, Integer nfsVersion) {
+        String mountPoint = setupMountPoint(parent);
+        if (mountPoint == null) {
+            s_logger.warn("Unable to create a mount point");
+            return null;
+        }
+
+        Script command = new Script(true, "mount", timeout, s_logger);
+        command.add("-t", "nfs");
+        if (nfsVersion != null){
+            command.add("-o", "vers=" + nfsVersion);
+        }
+        // command.add("-o", "soft,timeo=133,retrans=2147483647,tcp,acdirmax=0,acdirmin=0");
+        if ("Mac OS X".equalsIgnoreCase(System.getProperty("os.name"))) {
+            command.add("-o", "resvport");
+        }
+        command.add(path);
+        command.add(mountPoint);
+        String result = command.execute();
+        if (result != null) {
+            s_logger.warn("Unable to mount " + path + " due to " + result);
+            deleteMountPath(mountPoint);
+            return null;
+        }
+
+        // Change permissions for the mountpoint
+        Script script = new Script(true, "chmod", timeout, s_logger);
+        script.add("1777", mountPoint);
+        result = script.execute();
+        if (result != null) {
+            s_logger.warn("Unable to set permissions for " + mountPoint + " due to " + result);
+        }
+        return mountPoint;
+    }
+
+    private String setupMountPoint(String parent) {
+        String mountPoint = null;
+        for (int i = 0; i < 10; i++) {
+            String mntPt = parent + File.separator + String.valueOf(ManagementServerNode.getManagementServerId())
+ "." + Integer.toHexString(rand.nextInt(Integer.MAX_VALUE));
+            File file = new File(mntPt);
+            if (!file.exists()) {
+                if (storage.mkdir(mntPt)) {
+                    mountPoint = mntPt;
+                    break;
+                }
+            }
+            s_logger.error("Unable to create mount: " + mntPt);
+        }
 
 Review comment:
   so we are trying ten time and logging an error for each time. Than when done we return
null if we failed! I think we should improve this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message