cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP)
Date Thu, 12 Dec 2019 15:31:07 GMT
DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP)
URL: https://github.com/apache/cloudstack/pull/3748#discussion_r357174176
 
 

 ##########
 File path: server/src/main/java/com/cloud/template/HypervisorTemplateAdapter.java
 ##########
 @@ -330,8 +345,8 @@ private void createTemplateWithinZone(Long zId, TemplateProfile profile,
VMTempl
                         // Check if zone is disabled
                         if (Grouping.AllocationState.Disabled == zone.getAllocationState())
{
                             s_logger.info("Zone " + zoneId_is +
-                                    " is disabled, so skip downloading template to its image
store " + imageStore.getId());
-                            continue;
+                                    " is disabled, so uploading template to management server"
+ imageStore.getId());
+                            //continue;
 
 Review comment:
   please remove code in comments; delete this line or change to something like
   `                            // in this case we do not continue;`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message