cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP)
Date Thu, 12 Dec 2019 15:31:05 GMT
DaanHoogland commented on a change in pull request #3748: Systemvm template api (WIP)
URL: https://github.com/apache/cloudstack/pull/3748#discussion_r357125962
 
 

 ##########
 File path: api/src/main/java/org/apache/cloudstack/api/command/user/template/RegisterTemplateCmd.java
 ##########
 @@ -159,9 +161,22 @@
 
     @Parameter(name=ApiConstants.DIRECT_DOWNLOAD,
                 type = CommandType.BOOLEAN,
+                authorized = {RoleType.Admin},
                 description = "true if template should bypass Secondary Storage and be downloaded
to Primary Storage on deployment")
     private Boolean directDownload;
 
+    @Parameter(name = ApiConstants.SYSTEM,
+            type = CommandType.BOOLEAN,
+            authorized = {RoleType.Admin},
+            description = "true if it is a system vm template.")
+    private Boolean isSystem;
+
+    @Parameter(name=ApiConstants.ACTIVATE,
+            type = CommandType.BOOLEAN,
+            authorized = {RoleType.Admin},
+            description = "true if this template should be used by CloudStack to create System
VMs. Must be used with template type of 'system'.")
 
 Review comment:
   this description makes sense, but I see no check here that verifies. Please add or point
out to me ther errs of my ways.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message