cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #3738: Load Average for KVM
Date Tue, 03 Dec 2019 22:52:09 GMT
GabrielBrascher commented on a change in pull request #3738: Load Average for KVM
URL: https://github.com/apache/cloudstack/pull/3738#discussion_r353328415
 
 

 ##########
 File path: api/src/main/java/com/cloud/host/HostStats.java
 ##########
 @@ -35,6 +35,6 @@
 
     public HostStats getHostStats();
 
-    // public double getAverageLoad();
+    public double getLoadAverage();
     // public double getXapiMemoryUsageKBs();
 
 Review comment:
   I know that this is not related to this PR, but I guess the commented line `public double
getXapiMemoryUsageKBs();` can be deleted.
   
   Looks like it was meant to be a XenServer (Xen API) stats method, not a generic HostStats;
additionally, it was added long ago (in 2012).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message