cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [cloudstack] shwstppr commented on a change in pull request #3606: [WIP DO NOT MERGE] VM ingestion
Date Mon, 25 Nov 2019 07:55:53 GMT
shwstppr commented on a change in pull request #3606: [WIP DO NOT MERGE] VM ingestion
URL: https://github.com/apache/cloudstack/pull/3606#discussion_r350029521
 
 

 ##########
 File path: server/src/main/java/org/apache/cloudstack/vm/VmImportManagerImpl.java
 ##########
 @@ -233,10 +233,10 @@ private UnmanagedInstanceResponse createUnmanagedInstanceResponse(UnmanagedInsta
         response.setMemory(instance.getMemory());
         response.setOperatingSystemId(instance.getOperatingSystemId());
         response.setOperatingSystem(instance.getOperatingSystem());
-        response.setObjectName(UnmanagedInstance.class.getSimpleName().toLowerCase());
+        response.setObjectName("unmanagedinstance");
 
 Review comment:
   @DaanHoogland Because earlier the class name was `UnmanagedInstance` so it could be easily
used as object name for API response but since after review I changed the class name to `UnmanagedInstanceTO`
I had to explicitly mention object name

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message