cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [cloudstack] wido commented on a change in pull request #3704: utils: use iproute to get default network interface
Date Fri, 22 Nov 2019 11:37:02 GMT
wido commented on a change in pull request #3704: utils: use iproute to get default network
interface
URL: https://github.com/apache/cloudstack/pull/3704#discussion_r349554523
 
 

 ##########
 File path: utils/src/main/java/com/cloud/utils/net/NetUtils.java
 ##########
 @@ -268,19 +268,7 @@ public static String getDefaultEthDevice() {
             final String defDev = Script.runSimpleBashScript("/sbin/route -n get default
2> /dev/null | grep interface | awk '{print $2}'");
             return defDev;
         }
-        final String defaultRoute = Script.runSimpleBashScript("/sbin/route | grep default");
-
-        if (defaultRoute == null) {
-            return null;
-        }
-
-        final String[] defaultRouteList = defaultRoute.split("\\s+");
-
-        if (defaultRouteList.length != 8) {
-            return null;
-        }
-
-        return defaultRouteList[7];
+        return Script.runSimpleBashScript("ip route | grep default | head -1 | grep -Po '(?<=dev
)(\\S+)'");
 
 Review comment:
   I would suggest:
   
   <pre>
   ip route show default 0.0.0.0/0|head -1|awk '{print $3}'
   </pre>
   
   If a Host has a large routing table you can run into problems here. By fetching the route
for 0.0.0.0/0 you query the routing table faster.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message