cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [cloudstack] mdominka commented on a change in pull request #3186: Add possibility to set KVM MTU size for all NIC
Date Fri, 15 Nov 2019 10:22:23 GMT
mdominka commented on a change in pull request #3186: Add possibility to set KVM MTU size for
all NIC
URL: https://github.com/apache/cloudstack/pull/3186#discussion_r346753828
 
 

 ##########
 File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
 ##########
 @@ -1054,7 +1061,7 @@ public void validateCustomParameters(ServiceOfferingVO serviceOffering,
Map<Stri
 
             if (serviceOffering.getSpeed() == null) {
                 String cpuSpeed = customParameters.get(UsageEventVO.DynamicParameters.cpuSpeed.name());
-                if ((cpuSpeed == null) || (NumbersUtil.parseInt(cpuSpeed, -1) <= 0)) {
+                if ((cpuSpeed == null) || (parseInt(cpuSpeed, -1) <= 0)) {
 
 Review comment:
   I did not change this code (only static import), but I adapt that to StringUtils.isBlank().
Thanks for the hint.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message