cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [cloudstack] shwstppr commented on a change in pull request #3606: [WIP DO NOT MERGE] VM ingestion
Date Thu, 07 Nov 2019 06:20:31 GMT
shwstppr commented on a change in pull request #3606: [WIP DO NOT MERGE] VM ingestion
URL: https://github.com/apache/cloudstack/pull/3606#discussion_r343491413
 
 

 ##########
 File path: engine/schema/src/main/java/com/cloud/storage/VMTemplateVO.java
 ##########
 @@ -230,6 +230,13 @@ public static VMTemplateVO createPreHostIso(Long id, String uniqueName,
String n
         return template;
     }
 
+    public static VMTemplateVO createSystemIso(Long id, String uniqueName, String name, boolean
isPublic,
 
 Review comment:
   Import of  VM is allowed without using any template. But since CS needs a template or ISO
ID for a VM, we need to create a dummy, removed ISO which can be used for import in such cases.
Method to create dummy ISO DB record, https://github.com/apache/cloudstack/pull/3606/files#diff-3eaaf9de1645091dff197645123e669cR200

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message