From commits-return-91026-archive-asf-public=cust-asf.ponee.io@cloudstack.apache.org Mon Jul 8 19:10:50 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id A1442180665 for ; Mon, 8 Jul 2019 21:10:50 +0200 (CEST) Received: (qmail 39735 invoked by uid 500); 8 Jul 2019 19:10:50 -0000 Mailing-List: contact commits-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list commits@cloudstack.apache.org Received: (qmail 39725 invoked by uid 99); 8 Jul 2019 19:10:49 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 08 Jul 2019 19:10:49 +0000 From: GitBox To: commits@cloudstack.apache.org Subject: [GitHub] [cloudstack] ustcweizhou commented on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV Message-ID: <156261304487.25516.11065793226720666917.gitbox@gitbox.apache.org> Date: Mon, 08 Jul 2019 19:10:44 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit ustcweizhou commented on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV URL: https://github.com/apache/cloudstack/pull/3319#issuecomment-509353969 @rhtyd I am still -1 on this PR. @skattoju4 @svenvogel Does the issue happen other OSes than Windows ? I have tested os types windows/windows pv/other linux/ubuntu , all seem ok (the data disk is virtio), vms are running on NFS. So I think it is an issue with the disk definition in kvm plugin. look at the following lines in LibvirtComputingResource.java for NFS, the DATADISK has different disk bus type (diskBusTypeData = VIRTIO/SCSI) than ROOT disk (diskBusType = IDE/ VIRTIO/SCSI) ``` } else if (pool.getType() == StoragePoolType.CLVM || physicalDisk.getFormat() == PhysicalDiskFormat.RAW) { disk.defBlockBasedDisk(physicalDisk.getPath(), devId, diskBusType); } else { if (volume.getType() == Volume.Type.DATADISK) { disk.defFileBasedDisk(physicalDisk.getPath(), devId, diskBusTypeData, DiskDef.DiskFmtType.QCOW2); } else { disk.defFileBasedDisk(physicalDisk.getPath(), devId, diskBusType, DiskDef.DiskFmtType.QCOW2); } } ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services