cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [cloudstack] ustcweizhou commented on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV
Date Mon, 08 Jul 2019 21:17:34 GMT
ustcweizhou commented on issue #3319: Use IDE as the bus type for root disks and VIRTIO for
data disks when platform emulator strings start with Windows* except Windows PV
URL: https://github.com/apache/cloudstack/pull/3319#issuecomment-509395592
 
 
   > > @svenvogel Agree with you.
   > > Furthermore, I think it is better to use
   > > ```
   > > platformEmulator.contains("Ubuntu")
   > > ```
   > > 
   > > 
   > > because some users use "Other Ubuntu" for the Ubuntu versions which are not in
the list, for example Ubuntu 17.04, Ubuntu 18.04.
   > > > Regardless of this fix ... the code below should included in any case because
it looks ugly at the moment. (code below)
   > > > ```java
   > > >         } else if (platformEmulator.startsWith("Ubuntu") ||
   > > >                 platformEmulator.startsWith("Fedora") ||
   > > >                 platformEmulator.startsWith("CentOS") ||
   > > >                 platformEmulator.startsWith("Red Hat Enterprise Linux")
||
   > > >                 platformEmulator.startsWith("Debian GNU/Linux") ||
   > > >                 platformEmulator.startsWith("FreeBSD") ||
   > > >                 platformEmulator.startsWith("Oracle") ||
   > > >                 platformEmulator.startsWith("Windows PV") ||
   > > >                 platformEmulator.startsWith("Other PV")) {
   > > > ```
   > 
   > Are there any Ubuntu versions which don't support PV ?
   
   as far as  I know, pv is supported by all ubuntu versions in past 10 years.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message