cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [cloudstack] rhtyd commented on a change in pull request #3475: Allowing template owner to download template
Date Fri, 05 Jul 2019 17:19:06 GMT
rhtyd commented on a change in pull request #3475: Allowing template owner to download template
URL: https://github.com/apache/cloudstack/pull/3475#discussion_r300752991
 
 

 ##########
 File path: ui/scripts/templates.js
 ##########
 @@ -1378,12 +1378,7 @@
                                     isextractable: {
                                         label: 'label.extractable.lower',
                                         isBoolean: true,
-                                        isEditable: function() {
-                                            if (isAdmin())
-                                                return true;
-                                            else
-                                                return false;
-                                        },
+                                        isEditable: true,
 
 Review comment:
   Can you add a check to only allow editable option when it's either the root admin of when
template account matches the logged in user account? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message