cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [cloudstack] rhtyd commented on a change in pull request #3454: [WIP DO NOT MERGE] Add support for new heuristics based VM Deployement
Date Wed, 03 Jul 2019 07:05:10 GMT
rhtyd commented on a change in pull request #3454: [WIP DO NOT MERGE] Add support for new heuristics
based VM Deployement
URL: https://github.com/apache/cloudstack/pull/3454#discussion_r299803703
 
 

 ##########
 File path: api/src/main/java/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java
 ##########
 @@ -138,6 +140,12 @@
     @Parameter(name = ApiConstants.SSH_KEYPAIR, type = CommandType.STRING, description =
"name of the ssh key pair used to login to the virtual machine")
     private String sshKeyPairName;
 
+    @Parameter(name = ApiConstants.POD_ID, type = CommandType.UUID, entityType = PodResponse.class,
description = "destination Pod ID to deploy the VM to - parameter available for root admin
only")
 
 Review comment:
   Since the feature is defined for root admins, please move the changes to `DeployVMCmdByAdmin`
@anuragaw - we don't want normal users to be able to select pod and cluster. Also, see if
you want to move the hostId option (added in 923f562aa8d227332477261eb36d4156a1d21308).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message