From commits-return-90293-archive-asf-public=cust-asf.ponee.io@cloudstack.apache.org Fri Jun 28 10:54:14 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id C2BE418062B for ; Fri, 28 Jun 2019 12:54:13 +0200 (CEST) Received: (qmail 44314 invoked by uid 500); 28 Jun 2019 10:54:13 -0000 Mailing-List: contact commits-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list commits@cloudstack.apache.org Received: (qmail 44305 invoked by uid 99); 28 Jun 2019 10:54:13 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 28 Jun 2019 10:54:13 +0000 From: GitBox To: commits@cloudstack.apache.org Subject: [GitHub] [cloudstack] cl-k-takahashi opened a new issue #3442: UserDispersingPlanner only counts Running vms on hosts. Message-ID: <156171925308.29019.3593335620686997534.gitbox@gitbox.apache.org> Date: Fri, 28 Jun 2019 10:54:13 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit cl-k-takahashi opened a new issue #3442: UserDispersingPlanner only counts Running vms on hosts. URL: https://github.com/apache/cloudstack/issues/3442 ##### ISSUE TYPE * Improvement Request ##### COMPONENT NAME ~~~ UserDispersingPlanner.java ~~~ ##### CLOUDSTACK VERSION ~~~ Current version ~~~ ##### CONFIGURATION ##### OS / ENVIRONMENT ##### SUMMARY When you try to deploy multiple vms in a short time, their state will go to 'Starting' state. According to UserDispersingPlanner.java, it counts only Running vms on hosts to calculate priority of destination hosts to deploy vm. As a result, these vms can concentrate to one host if we try to deploy vms in a short time. To avoid this, I think we should count not only Running vms but also Starting vms. ``` Long totalVmsOfAccount = vmInstanceDao.countRunningByAccount(accountId); if (s_logger.isDebugEnabled()) { s_logger.debug("Total VMs for account: " + totalVmsOfAccount); } ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services