From commits-return-89261-archive-asf-public=cust-asf.ponee.io@cloudstack.apache.org Tue Jun 11 17:24:30 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 7EB9F180627 for ; Tue, 11 Jun 2019 19:24:30 +0200 (CEST) Received: (qmail 51998 invoked by uid 500); 11 Jun 2019 17:24:29 -0000 Mailing-List: contact commits-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list commits@cloudstack.apache.org Received: (qmail 51989 invoked by uid 99); 11 Jun 2019 17:24:29 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 Jun 2019 17:24:29 +0000 From: GitBox To: commits@cloudstack.apache.org Subject: [GitHub] [cloudstack] matheusdaluz commented on a change in pull request #3389: when destroy the vms, delete the tags from virtual router Message-ID: <156027386941.32402.1731947963275453079.gitbox@gitbox.apache.org> Date: Tue, 11 Jun 2019 17:24:29 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit matheusdaluz commented on a change in pull request #3389: when destroy the vms, delete the tags from virtual router URL: https://github.com/apache/cloudstack/pull/3389#discussion_r292479466 ########## File path: server/src/test/java/com/cloud/vm/UserVmManagerImplTest.java ########## @@ -276,4 +285,36 @@ private void configureValidateOrReplaceMacAddressTest(int times, String macAddre Mockito.verify(networkModel, Mockito.times(times)).getNextAvailableMacAddressInNetwork(Mockito.anyLong()); Assert.assertEquals(expectedMacAddress, returnedMacAddress); } + + @Test + public void validateRemoveTagsWhenExists() { Review comment: unfortunately is not easy to test. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services