cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [cloudstack] anuragaw opened a new pull request #3445: Fix sorting order bug in UI Code with usage of sortkey.algorithm global config
Date Sat, 29 Jun 2019 13:01:19 GMT
anuragaw opened a new pull request #3445: Fix sorting order bug in UI Code with usage of sortkey.algorithm
global config
URL: https://github.com/apache/cloudstack/pull/3445
 
 
   Current master has sorting broken and the order reverses as opposed to
   what is set if sortkey.algorithm is set to true. The problem lies in the
   way the update APIs were being called by the UI. The code was agnostic
   to a global config that backend uses to set the order of the entities
   in the corresponding list APIs.
   
   We need to make UI aware of the global config and instead of changing
   sign of sort key pass proper numbers so that DB isn't confusing when
   some tables have positive sortkey and some have negative.
   
   The fix is in 2 steps-
   1) Make use of sortkey name in place where it's relevant. Mere row index
   is not sufficient.
   2) Reverse the sortkey if we are sorting by descending (when global
   config is false)
   
   ## Description
   <!--- Describe your changes in detail -->
   
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed
when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   Fix is general bugfix but I also verified that #2724 is also fixed after this change and
verifiable. The DB support already existed.
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the boxes that
apply: -->
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [x] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   
   ## How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   <!-- see how your change affects other areas of the code, etc. -->
   
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md)
document -->
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message