cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [cloudstack] anuragaw commented on a change in pull request #3306: server: reduce execution time while listing project if projects have many resource tags
Date Sat, 29 Jun 2019 08:57:25 GMT
anuragaw commented on a change in pull request #3306: server: reduce execution time while listing
project if projects have many resource tags
URL: https://github.com/apache/cloudstack/pull/3306#discussion_r298793354
 
 

 ##########
 File path: server/src/main/java/com/cloud/api/query/dao/ProjectJoinDaoImpl.java
 ##########
 @@ -101,14 +99,6 @@ public ProjectResponse newProjectResponse(ProjectJoinVO proj) {
 
     @Override
     public ProjectResponse setProjectResponse(ProjectResponse rsp, ProjectJoinVO proj) {
 
 Review comment:
   Sounds good. I think we should make this simple change then to make code cleaner and easy
to comprehend in this PR. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message