cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [cloudstack] anuragaw commented on a change in pull request #3425: [WIP DO NOT MERGE] Better tracking host maintanence success and failure
Date Thu, 27 Jun 2019 04:44:36 GMT
anuragaw commented on a change in pull request #3425: [WIP DO NOT MERGE] Better tracking host
maintanence success and failure
URL: https://github.com/apache/cloudstack/pull/3425#discussion_r298003491
 
 

 ##########
 File path: server/src/main/java/com/cloud/resource/ResourceManagerImpl.java
 ##########
 @@ -2981,6 +2991,6 @@ public String getConfigComponentName() {
 
     @Override
     public ConfigKey<?>[] getConfigKeys() {
-        return new ConfigKey<?>[] {HostMaintenanceRetries};
+        return new ConfigKey<?>[] {KvmSshToAgentEnabled};
 
 Review comment:
   For the sake of completeness (readability) should we not export it anyway? I mean if there
are no repurcussions to it we should we not keep it as is?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message