cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [cloudstack] rhtyd commented on a change in pull request #3421: RvR: VPC redundant vrs run on same hypervisor
Date Tue, 25 Jun 2019 08:14:49 GMT
rhtyd commented on a change in pull request #3421: RvR: VPC redundant vrs run on same hypervisor
URL: https://github.com/apache/cloudstack/pull/3421#discussion_r297060395
 
 

 ##########
 File path: server/src/com/cloud/network/router/NetworkHelperImpl.java
 ##########
 @@ -388,6 +388,19 @@ public DomainRouterVO startVirtualRouter(final DomainRouterVO router,
final User
                     routerToBeAvoid = rrouter;
                 }
             }
+        } else if (router.getVpcId() != null) {
+            final List<DomainRouterVO> routerList = _routerDao.listByVpcId(router.getVpcId());
+            for (final DomainRouterVO rrouter : routerList) {
+                if (rrouter.getHostId() != null && rrouter.getIsRedundantRouter()
&& rrouter.getState() == State.Running) {
+                    if (routerToBeAvoid != null) {
 
 Review comment:
   should this also check that the routerList.size() is >= 2?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message