cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [cloudstack] matheusdaluz commented on a change in pull request #3389: when destroy the vms, delete the tags from virtual router
Date Tue, 11 Jun 2019 17:24:29 GMT
matheusdaluz commented on a change in pull request #3389: when destroy the vms, delete the
tags from virtual router
URL: https://github.com/apache/cloudstack/pull/3389#discussion_r292479466
 
 

 ##########
 File path: server/src/test/java/com/cloud/vm/UserVmManagerImplTest.java
 ##########
 @@ -276,4 +285,36 @@ private void configureValidateOrReplaceMacAddressTest(int times, String
macAddre
         Mockito.verify(networkModel, Mockito.times(times)).getNextAvailableMacAddressInNetwork(Mockito.anyLong());
         Assert.assertEquals(expectedMacAddress, returnedMacAddress);
     }
+
+    @Test
+    public void validateRemoveTagsWhenExists() {
 
 Review comment:
   unfortunately is not easy to test.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message