From commits-return-87427-archive-asf-public=cust-asf.ponee.io@cloudstack.apache.org Fri May 10 20:30:35 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 163E118061A for ; Fri, 10 May 2019 22:30:34 +0200 (CEST) Received: (qmail 93339 invoked by uid 500); 10 May 2019 20:30:34 -0000 Mailing-List: contact commits-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list commits@cloudstack.apache.org Received: (qmail 93330 invoked by uid 99); 10 May 2019 20:30:34 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 10 May 2019 20:30:34 +0000 From: GitBox To: commits@cloudstack.apache.org Subject: [GitHub] [cloudstack] svenvogel edited a comment on issue #3319: Use virtio for platform emulator strings starting with Windows* Message-ID: <155752023436.7099.2768597554854904381.gitbox@gitbox.apache.org> Date: Fri, 10 May 2019 20:30:34 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit svenvogel edited a comment on issue #3319: Use virtio for platform emulator strings starting with Windows* URL: https://github.com/apache/cloudstack/pull/3319#issuecomment-491415223 @skattoju4 @ustcweizhou @syed i will try to explain it. > @ustcweizhou the thinking behind always setting the root disk to ide was to be able to boot a windows vm regardless of whether or not virtio drivers were installed. That said setting all disks to virtio when selecting "Windows PV" when registering the template is one way to move forward. first i have to say is yes! let me explain. as written in #3089 we have "NOT" only the problem with template! @DennisKonrad wrote: When we select "Windows Server 2016 (64-bit)" as OS Type for an **W2K16 cd image** the resulting VMs will not start with multiple disks attached. This is due to the usage of multiple IDE interfaces in the VM description XML. 1. we create a machine with "Windows Server 2016 (64-bit)" we have **one** disk with type root "ide". Bildschirmfoto 2019-05-10 um 21 50 40 2. after that we add **two more data disks** and those should "NOT" be IDE because QEMU dont like this! When we use NFS the second and third disk will be a "virtio" disk automatically. this pr should "NOT" remove/break or add functionality. it should enable the normal functionality for managed storage according to NFS works and it is needed by QEMU if we choose "Windows Server 201X..." as OS Type. it is a bug that will affect only managed storage (as far as i i know). If any user wants "ONLY" virtio driver he can choose "other pv ..." OS Type. Bildschirmfoto 2019-05-10 um 21 58 11 there is no discussion about performance of IDE or move all Microsoft Windows OS Types to virtio. it should be clear for everybody here that virtio is faster than ide and yes we dont need a driver for the root disk. but this content is not part of this discussion here. i hope it is more clear now? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services