cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [cloudstack] rhtyd commented on a change in pull request #3333: server: ssh-keygen in PEM format and reduce main systemvm patching script
Date Thu, 23 May 2019 07:30:39 GMT
rhtyd commented on a change in pull request #3333: server: ssh-keygen in PEM format and reduce
main systemvm patching script
URL: https://github.com/apache/cloudstack/pull/3333#discussion_r286810482
 
 

 ##########
 File path: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
 ##########
 @@ -1362,7 +1362,7 @@ private boolean checkOvsNetwork(final String networkName) {
     }
 
     public boolean passCmdLine(final String vmName, final String cmdLine) throws InternalErrorException
{
-        final Script command = new Script(_patchScriptPath, 30 * 1000, s_logger);
+        final Script command = new Script(_patchScriptPath, 300 * 1000, s_logger);
 
 Review comment:
   In environment with slow cpu and storage network, the timeout may be even higher. The logic
of 5minute timeout comes from the libvirt wrapper command handler:
   ```
                   // try to patch and SSH into the systemvm for up to 5 minutes
                   for (int count = 0; count < 10; count++) {
   ```
   For historic reasons, you can see CLOUDSTACK-2823

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message