cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [cloudstack] rhtyd commented on a change in pull request #3333: server: ssh-keygen in PEM format and reduce main systemvm patching script
Date Tue, 21 May 2019 07:42:31 GMT
rhtyd commented on a change in pull request #3333: server: ssh-keygen in PEM format and reduce
main systemvm patching script
URL: https://github.com/apache/cloudstack/pull/3333#discussion_r285889257
 
 

 ##########
 File path: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtStartCommandWrapper.java
 ##########
 @@ -125,9 +125,14 @@ public Answer execute(final StartCommand command, final LibvirtComputingResource
                 // try to patch and SSH into the systemvm for up to 5 minutes
                 for (int count = 0; count < 10; count++) {
                     // wait and try passCmdLine for 30 seconds at most for CLOUDSTACK-2823
-                    libvirtComputingResource.passCmdLine(vmName, vmSpec.getBootArgs());
-                    // check router is up?
-                    final VirtualRoutingResource virtRouterResource = libvirtComputingResource.getVirtRouterResource();
+                    if (libvirtComputingResource.passCmdLine(vmName, vmSpec.getBootArgs()))
{
+                        break;
+                    }
 
 Review comment:
   @ustcweizhou the blind waiting and passing cmdline is not necessary now, in the new patch.sh
script it waits until it's able to communicate with the qemu-guest-agent running inside the
systemvm appliance. See: https://github.com/apache/cloudstack/blob/master/scripts/vm/hypervisor/kvm/patch.sh#L61

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message