From commits-return-86734-archive-asf-public=cust-asf.ponee.io@cloudstack.apache.org Tue Apr 9 08:13:25 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id DD647180629 for ; Tue, 9 Apr 2019 10:13:24 +0200 (CEST) Received: (qmail 39150 invoked by uid 500); 9 Apr 2019 07:53:46 -0000 Mailing-List: contact commits-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list commits@cloudstack.apache.org Received: (qmail 39141 invoked by uid 99); 9 Apr 2019 07:53:46 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 09 Apr 2019 07:53:46 +0000 From: GitBox To: commits@cloudstack.apache.org Subject: [GitHub] [cloudstack] anuragaw commented on a change in pull request #3258: [WIP DO NOT MERGE] Configure hiding table columns through config.js file Message-ID: <155479760414.5568.15076698436734121429.gitbox@gitbox.apache.org> Date: Tue, 09 Apr 2019 08:13:24 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit anuragaw commented on a change in pull request #3258: [WIP DO NOT MERGE] Configure hiding table columns through config.js file URL: https://github.com/apache/cloudstack/pull/3258#discussion_r273373114 ########## File path: ui/scripts/ui/widgets/listView.js ########## @@ -860,6 +860,8 @@ if (groupableColumns) { $tr.addClass('groupable-header-columns').addClass('groupable-header'); $.each(fields, function(key) { Review comment: This was broken in existing code and needed fixing. If an upper field is hidden we must not draw it's containing columns. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services