cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [cloudstack] anuragaw commented on a change in pull request #3258: [WIP DO NOT MERGE] Configure hiding table columns through config.js file
Date Tue, 09 Apr 2019 08:13:24 GMT
anuragaw commented on a change in pull request #3258:  [WIP DO NOT MERGE] Configure hiding
table columns through config.js file
URL: https://github.com/apache/cloudstack/pull/3258#discussion_r273373114
 
 

 ##########
 File path: ui/scripts/ui/widgets/listView.js
 ##########
 @@ -860,6 +860,8 @@
         if (groupableColumns) {
             $tr.addClass('groupable-header-columns').addClass('groupable-header');
             $.each(fields, function(key) {
 
 Review comment:
   This was broken in existing code and needed fixing. If an upper field is hidden we must
not draw it's containing columns.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message