cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [cloudstack] anuragaw opened a new pull request #3268: Support sort_key for vpc_offerings table
Date Mon, 08 Apr 2019 10:35:40 GMT
anuragaw opened a new pull request #3268: Support sort_key for vpc_offerings table
URL: https://github.com/apache/cloudstack/pull/3268
 
 
   Fixes- #2742
   
   UI Supported ordering VPC Offerings but the API did not have that
   support implemented. This makes the change in updateVPCOfferings
   and listVPCOfferings API calls, along with necessary database
   changes for supporting sorting of VPC Offerings.
   
   ## Description
   <!--- Describe your changes in detail -->
   
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed
when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the boxes that
apply: -->
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   Added column to Database -
   ![Screenshot from 2019-04-08 15-18-35](https://user-images.githubusercontent.com/43956255/55717891-fb65a100-5a17-11e9-9688-6777b74f110d.png)
   ## How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   <!-- see how your change affects other areas of the code, etc. -->
   
   Load the UI and sort VPC Offerings. Ensure the order persists. Make sure issue 2742 is
not reproducible.
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md)
document -->
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message