cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] pbankonier opened a new pull request #3199: Fix ip V4 and ip v4 cidr column sorting in tables
Date Thu, 28 Feb 2019 12:38:47 GMT
pbankonier opened a new pull request #3199: Fix ip V4 and ip v4 cidr column sorting in tables
URL: https://github.com/apache/cloudstack/pull/3199
 
 
   ## Description
   This fixes the sorting of ip addresses and ip cidrs.
   Currently they get evaluated as a numeric value via parseFloat and sorted as numeric values.
   For example "10.32.123.123" got parsed to 10.32.  
   
   ## Types of changes
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## How Has This Been Tested?
   Deployed this to our test environment and tested functionality.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message