cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] GabrielBrascher commented on a change in pull request #3133: feature: add libvirt / qemu io bursting
Date Thu, 17 Jan 2019 12:44:48 GMT
GabrielBrascher commented on a change in pull request #3133: feature: add libvirt / qemu io
bursting
URL: https://github.com/apache/cloudstack/pull/3133#discussion_r248655559
 
 

 ##########
 File path: plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java
 ##########
 @@ -581,9 +581,17 @@ public String toString() {
         private boolean _shareable = false;
         private boolean _deferAttach = false;
         private Long _bytesReadRate;
+        private Long _bytesReadRateMax;
 
 Review comment:
   Yes, unfortunately, they are using the `_`. That is why I am +1 on removing `_` in any
new code that goes into the master, and slowly improve the CloudStack codebase.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message