cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] wido commented on a change in pull request #3113: kvm: Security Group enhancements and refactor old code
Date Mon, 07 Jan 2019 09:18:41 GMT
wido commented on a change in pull request #3113: kvm: Security Group enhancements and refactor
old code
URL: https://github.com/apache/cloudstack/pull/3113#discussion_r245588687
 
 

 ##########
 File path: scripts/vm/network/security_group.py
 ##########
 @@ -35,11 +33,6 @@
 logpath = "/var/run/cloud/"        # FIXME: Logs should reside in /var/log/cloud
 
 Review comment:
   I am not sure what the implications might be.
   
   People might be parsing the files at that location, but also, if they are in /var/run/cloud
they will be gone after a reboot (which is good!)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message