cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] GabrielBrascher commented on a change in pull request #2997: Allow KVM VM live migration with ROOT volume on file storage type
Date Thu, 13 Dec 2018 18:06:13 GMT
GabrielBrascher commented on a change in pull request #2997: Allow KVM VM live migration with
ROOT volume on file storage type
URL: https://github.com/apache/cloudstack/pull/2997#discussion_r241504968
 
 

 ##########
 File path: plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/MigrateKVMAsync.java
 ##########
 @@ -36,6 +36,36 @@
     private boolean migrateStorage;
     private boolean autoConvergence;
 
+    /**
+     * Do not pause the domain during migration. The domain's memory will be transferred
to the destination host while the domain is running. The migration may never converge if the
domain is changing its memory faster then it can be transferred. The domain can be manually
paused anytime during migration using virDomainSuspend.
+     * @value 1
+     * @see Libvirt <a href="https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainMigrateFlags">virDomainMigrateFlags</a>
documentation
+     */
+    private static final long VIR_MIGRATE_LIVE = 1l;
 
 Review comment:
   Done!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message