cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] mike-tutkowski commented on a change in pull request #2983: KVM live storage migration intra cluster from NFS source and destination
Date Thu, 01 Nov 2018 01:46:42 GMT
mike-tutkowski commented on a change in pull request #2983: KVM live storage migration intra
cluster from NFS source and destination
URL: https://github.com/apache/cloudstack/pull/2983#discussion_r229917392
 
 

 ##########
 File path: engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
 ##########
 @@ -1991,8 +2198,49 @@ private void verifyLiveMigrationMapForKVM(Map<VolumeInfo, DataStore>
volumeDataS
                 throw new CloudRuntimeException("Destination storage pool with ID " + dataStore.getId()
+ " was not located.");
             }
 
+            if (storageTypeConsistency == null) {
 
 Review comment:
   Won't this expression always evaluate to true?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message