From commits-return-81409-archive-asf-public=cust-asf.ponee.io@cloudstack.apache.org Wed Oct 17 09:20:42 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 990E1180674 for ; Wed, 17 Oct 2018 09:20:41 +0200 (CEST) Received: (qmail 24505 invoked by uid 500); 17 Oct 2018 07:20:40 -0000 Mailing-List: contact commits-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list commits@cloudstack.apache.org Received: (qmail 24486 invoked by uid 99); 17 Oct 2018 07:20:40 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 17 Oct 2018 07:20:40 +0000 From: GitBox To: commits@cloudstack.apache.org Subject: [GitHub] rhtyd commented on a change in pull request #2869: Fix some Marvin smoke tests Message-ID: <153976084009.8986.16901812056834266160.gitbox@gitbox.apache.org> Date: Wed, 17 Oct 2018 07:20:40 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit rhtyd commented on a change in pull request #2869: Fix some Marvin smoke tests URL: https://github.com/apache/cloudstack/pull/2869#discussion_r225804706 ########## File path: test/integration/smoke/test_vm_life_cycle.py ########## @@ -907,9 +907,10 @@ def unsecure_host(self, host): sed -i 's/listen_tcp.*/listen_tcp=1/g' /etc/libvirt/libvirtd.conf && \ sed -i '/.*_file=.*/d' /etc/libvirt/libvirtd.conf && \ service libvirtd restart && \ + sleep 30 && \ service cloudstack-agent restart") - - time.sleep(10) + + time.sleep(30) Review comment: Why do we need to sleep? Could be do a wait_until check here instead? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services