From commits-return-81290-archive-asf-public=cust-asf.ponee.io@cloudstack.apache.org  Mon Oct 15 15:50:37 2018
Return-Path: <commits-return-81290-archive-asf-public=cust-asf.ponee.io@cloudstack.apache.org>
X-Original-To: archive-asf-public@cust-asf.ponee.io
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx-eu-01.ponee.io (Postfix) with SMTP id 6F8FA180674
	for <archive-asf-public@cust-asf.ponee.io>; Mon, 15 Oct 2018 15:50:37 +0200 (CEST)
Received: (qmail 35253 invoked by uid 500); 15 Oct 2018 13:50:36 -0000
Mailing-List: contact commits-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:commits-help@cloudstack.apache.org>
List-Unsubscribe: <mailto:commits-unsubscribe@cloudstack.apache.org>
List-Post: <mailto:commits@cloudstack.apache.org>
List-Id: <commits.cloudstack.apache.org>
Reply-To: dev@cloudstack.apache.org
Delivered-To: mailing list commits@cloudstack.apache.org
Received: (qmail 35244 invoked by uid 99); 15 Oct 2018 13:50:36 -0000
Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 15 Oct 2018 13:50:36 +0000
From: GitBox <git@apache.org>
To: commits@cloudstack.apache.org
Subject: [GitHub] nvazquez opened a new pull request #2902: Add checksum sanity
 validation on template registration
Message-ID: <153961143595.6146.18408421412359818585.gitbox@gitbox.apache.org>
Date: Mon, 15 Oct 2018 13:50:35 -0000
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit

nvazquez opened a new pull request #2902: Add checksum sanity validation on template registration
URL: https://github.com/apache/cloudstack/pull/2902
 
 
   ## Description
   Add a checksum sanity check on template/ISO registration for direct downloads on KVM.
   Assert that:
   - Algorithm is provided as a prefix between braces on the checksum parameter: `Format: {ALG}HASH`
   - Hash length matches the expected one for the provided algorithm
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## GitHub Issue/PRs
   
   ## Screenshots (if appropriate):
   
   ## How Has This Been Tested?
   
   ## Checklist:
   <!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
   <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
   - [x] I have read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document.
   - [x] My code follows the code style of this project.
   - [ ] My change requires a change to the documentation.
   - [ ] I have updated the documentation accordingly.
   Testing
   - [ ] I have added tests to cover my changes.
   - [ ] All relevant new and existing integration tests have passed.
   - [ ] A full integration testsuite with all test that can run on my environment has passed.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services