cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] rhtyd commented on a change in pull request #2869: Fix some Marvin smoke tests
Date Wed, 17 Oct 2018 07:20:40 GMT
rhtyd commented on a change in pull request #2869: Fix some Marvin smoke tests
URL: https://github.com/apache/cloudstack/pull/2869#discussion_r225804706
 
 

 ##########
 File path: test/integration/smoke/test_vm_life_cycle.py
 ##########
 @@ -907,9 +907,10 @@ def unsecure_host(self, host):
                       sed -i 's/listen_tcp.*/listen_tcp=1/g' /etc/libvirt/libvirtd.conf &&
\
                       sed -i '/.*_file=.*/d' /etc/libvirt/libvirtd.conf && \
                       service libvirtd restart && \
+                      sleep 30 && \
                       service cloudstack-agent restart")
-
-        time.sleep(10)
+ 
+        time.sleep(30)
 
 Review comment:
   Why do we need to sleep? Could be do a wait_until check here instead?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message