From commits-return-78912-archive-asf-public=cust-asf.ponee.io@cloudstack.apache.org Mon Jul 23 19:28:52 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 96A14180647 for ; Mon, 23 Jul 2018 19:28:51 +0200 (CEST) Received: (qmail 455 invoked by uid 500); 23 Jul 2018 17:28:50 -0000 Mailing-List: contact commits-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list commits@cloudstack.apache.org Received: (qmail 439 invoked by uid 99); 23 Jul 2018 17:28:50 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 23 Jul 2018 17:28:50 +0000 From: GitBox To: commits@cloudstack.apache.org Subject: [GitHub] rafaelweingartner commented on a change in pull request #2762: Make HTTP handler of embedded server to be configured Message-ID: <153236693012.26978.12973754951598391137.gitbox@gitbox.apache.org> Date: Mon, 23 Jul 2018 17:28:50 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit rafaelweingartner commented on a change in pull request #2762: Make HTTP handler of embedded server to be configured URL: https://github.com/apache/cloudstack/pull/2762#discussion_r204489664 ########## File path: client/src/main/java/org/apache/cloudstack/ServerDaemon.java ########## @@ -163,11 +171,13 @@ public void start() throws Exception { httpConfig.setSendDateHeader(false); // HTTP Connector - final ServerConnector httpConnector = new ServerConnector(server, new HttpConnectionFactory(httpConfig)); - httpConnector.setPort(httpPort); - httpConnector.setHost(bindInterface); - httpConnector.setIdleTimeout(30000); - server.addConnector(httpConnector); + if (httpEnable) { + final ServerConnector httpConnector = new ServerConnector(server, new HttpConnectionFactory(httpConfig)); Review comment: What about extracting this block to a method? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services