cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] rafaelweingartner commented on a change in pull request #2762: Make HTTP handler of embedded server to be configured
Date Mon, 23 Jul 2018 17:28:50 GMT
rafaelweingartner commented on a change in pull request #2762: Make HTTP handler of embedded
server to be configured
URL: https://github.com/apache/cloudstack/pull/2762#discussion_r204489664
 
 

 ##########
 File path: client/src/main/java/org/apache/cloudstack/ServerDaemon.java
 ##########
 @@ -163,11 +171,13 @@ public void start() throws Exception {
         httpConfig.setSendDateHeader(false);
 
         // HTTP Connector
-        final ServerConnector httpConnector = new ServerConnector(server, new HttpConnectionFactory(httpConfig));
-        httpConnector.setPort(httpPort);
-        httpConnector.setHost(bindInterface);
-        httpConnector.setIdleTimeout(30000);
-        server.addConnector(httpConnector);
+        if (httpEnable) {
+            final ServerConnector httpConnector = new ServerConnector(server, new HttpConnectionFactory(httpConfig));
 
 Review comment:
   What about extracting this block to a method?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message