From commits-return-77614-archive-asf-public=cust-asf.ponee.io@cloudstack.apache.org Thu Jun 7 07:53:15 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id CA77B180663 for ; Thu, 7 Jun 2018 07:53:14 +0200 (CEST) Received: (qmail 52179 invoked by uid 500); 7 Jun 2018 05:53:13 -0000 Mailing-List: contact commits-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list commits@cloudstack.apache.org Received: (qmail 52170 invoked by uid 99); 7 Jun 2018 05:53:13 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 07 Jun 2018 05:53:13 +0000 From: GitBox To: commits@cloudstack.apache.org Subject: [GitHub] rhtyd commented on issue #2683: Add default L2 network offerings Message-ID: <152835079325.2269.14049456327111003170.gitbox@gitbox.apache.org> Date: Thu, 07 Jun 2018 05:53:13 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit rhtyd commented on issue #2683: Add default L2 network offerings URL: https://github.com/apache/cloudstack/pull/2683#issuecomment-395301428 Based on code reviews and tests LGTM. I also see that it now adds the default offerings only if they don't exist already. Merging this now. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services