cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] rhtyd commented on a change in pull request #2681: Issue 2680: Source NAT option on Private Gateway
Date Fri, 08 Jun 2018 08:32:35 GMT
rhtyd commented on a change in pull request #2681: Issue 2680: Source NAT option on Private
Gateway
URL: https://github.com/apache/cloudstack/pull/2681#discussion_r193987691
 
 

 ##########
 File path: systemvm/debian/opt/cloud/bin/cs/CsAddress.py
 ##########
 @@ -476,7 +476,12 @@ def fw_vpcrouter(self):
             self.fw.append(["", "front", "-A NETWORK_STATS_%s -o %s -s %s" %
                             ("eth1", "eth1", guestNetworkCidr)])
 
-            self.fw.append(["nat", "front",
+            if self.address["source_nat"]:
 
 Review comment:
   @ustcweizhou @rafaelweingartner @GabrielBrascher can you help review and test this? /cc
@PaulAngus @DaanHoogland 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message