cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] DaanHoogland commented on a change in pull request #2653: Generate MAC address if the MAC in command addNicToVirtualMachine is invalid
Date Fri, 18 May 2018 09:45:50 GMT
DaanHoogland commented on a change in pull request #2653: Generate MAC address if the MAC in
command addNicToVirtualMachine is invalid
URL: https://github.com/apache/cloudstack/pull/2653#discussion_r189216425
 
 

 ##########
 File path: server/src/com/cloud/vm/UserVmManagerImpl.java
 ##########
 @@ -1228,12 +1230,22 @@ public UserVm addNicToVirtualMachine(AddNicToVMCmd cmd) throws InvalidParameterV
         return _vmDao.findById(vmInstance.getId());
     }
 
+    /**
+     * If the given MAC address is invalid it returns the next available MAC address
+     */
+    protected String lookForNextAvailableMacAddressInNetworkIfMacIsInvalid(String macAddress,
long networkId) {
 
 Review comment:
   how about a shorter method name? validateOrReplaceMacAddress()?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message