cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] rhtyd commented on a change in pull request #2508: CLOUDSTACK-9114: Reduce VR downtime during network restart
Date Tue, 08 May 2018 12:17:56 GMT
rhtyd commented on a change in pull request #2508: CLOUDSTACK-9114: Reduce VR downtime during
network restart
URL: https://github.com/apache/cloudstack/pull/2508#discussion_r186706818
 
 

 ##########
 File path: api/src/org/apache/cloudstack/api/command/user/vpc/RestartVPCCmd.java
 ##########
 @@ -66,14 +66,14 @@ public Boolean getCleanup() {
         if (cleanup != null) {
             return cleanup;
         }
-        return true;
+        return false;
     }
 
     public Boolean getMakeredundant() {
         if (makeredundant != null) {
 
 Review comment:
   I see what you want, to set a default 'false' value and simply do a return.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message