cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] khos2ow commented on a change in pull request #2585: Add ability to archive snapshots on primary storage
Date Thu, 19 Apr 2018 20:13:34 GMT
khos2ow commented on a change in pull request #2585: Add ability to archive snapshots on primary
storage
URL: https://github.com/apache/cloudstack/pull/2585#discussion_r182870720
 
 

 ##########
 File path: server/src/main/java/com/cloud/server/ManagementServerImpl.java
 ##########
 @@ -2820,6 +2821,7 @@ public long getMemoryOrCpuCapacityByHost(final Long hostId, final short
capacity
         cmdList.add(CreateSnapshotCmd.class);
         cmdList.add(CreateSnapshotFromVMSnapshotCmd.class);
         cmdList.add(DeleteSnapshotCmd.class);
+        cmdList.add(ArchiveSnapshotCmd.class);
 
 Review comment:
   @syed I believe you forgot to commit `ArchiveSnapshotCmd` itself!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message