cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ro...@apache.org
Subject [cloudstack] branch 4.11 updated: systemvm: Use double quotes with 'RROUTER' variable in "common.sh" script (#2586)
Date Thu, 19 Apr 2018 18:57:55 GMT
This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch 4.11
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/4.11 by this push:
     new 9288c64  systemvm: Use double quotes with 'RROUTER' variable in "common.sh" script
(#2586)
9288c64 is described below

commit 9288c64e5f618e45844f19a902f022c9c9dec8b9
Author: Rafael Weingärtner <rafaelweingartner@gmail.com>
AuthorDate: Thu Apr 19 15:57:45 2018 -0300

    systemvm: Use double quotes with 'RROUTER' variable in "common.sh" script (#2586)
    
    While debugging the VR for #2579, I noticed that one of the scripts were breaking. The
variable RROUTER was not set and this broke a conditional.
    
    Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
---
 systemvm/debian/opt/cloud/bin/setup/common.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/systemvm/debian/opt/cloud/bin/setup/common.sh b/systemvm/debian/opt/cloud/bin/setup/common.sh
index e24a277..d2a26c9 100755
--- a/systemvm/debian/opt/cloud/bin/setup/common.sh
+++ b/systemvm/debian/opt/cloud/bin/setup/common.sh
@@ -585,7 +585,7 @@ routing_svcs() {
    systemctl enable haproxy
    echo "haproxy apache2" > /var/cache/cloud/enabled_svcs
    echo "cloud nfs-common portmap" > /var/cache/cloud/disabled_svcs
-   if [ $RROUTER -eq 1 ]
+   if [ "$RROUTER" -eq "1" ]
    then
        systemctl disable --now dnsmasq
        systemctl enable conntrackd

-- 
To stop receiving notification emails like this one, please contact
rohit@apache.org.

Mime
View raw message