cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] rafaelweingartner commented on a change in pull request #2578: api: add command to list management servers
Date Wed, 18 Apr 2018 11:45:16 GMT
rafaelweingartner commented on a change in pull request #2578: api: add command to list management
servers
URL: https://github.com/apache/cloudstack/pull/2578#discussion_r182397190
 
 

 ##########
 File path: api/src/main/java/com/cloud/management/ManagementServerHost.java
 ##########
 @@ -14,19 +14,23 @@
 // KIND, either express or implied.  See the License for the
 // specific language governing permissions and limitations
 // under the License.
-package com.cloud.cluster;
+package com.cloud.management;
 
 public interface ManagementServerHost {
+    enum State {
+        Up, Starting, Down
 
 Review comment:
   `Down`, I have seen in the database.
   
   ```
   -------------------------------------------------------------------------------------------------------------
   | name                  | state | version | service_ip     | service_port | last_update
          | removed |
   | --------------------- | ----- | ------- | -------------- | ------------ | ---------------------
| ------- |
   | ubuntu-acs            | Up    | 4.9.3.0 | 127.0.0.1      | 9090         | 2018-01-24
21:46:26.0 | <null>  |
   | localhost.localdomain | Down  | 4.9.3.0 | 192.168.0.23 | 9090         | 2018-01-24 16:10:54.0
| <null>  |
   -------------------------------------------------------------------------------------------------------------
   ```
   
   If the state `Starting` is not used, we can remove it.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message