cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] GabrielBrascher commented on issue #2524: [CLOUDSTACK-9261] Upgrate jQuery-UI to 1.11 (JQuery UI 1.8.4 prone to XSS)
Date Mon, 16 Apr 2018 20:33:12 GMT
GabrielBrascher commented on issue #2524: [CLOUDSTACK-9261] Upgrate jQuery-UI to 1.11 (JQuery
UI 1.8.4 prone to XSS)
URL: https://github.com/apache/cloudstack/pull/2524#issuecomment-381739698
 
 
   I spent some time testing it in a test environment and seems to be all good. However, two
buttons need some attention:
   (i) 'About' button: here the user cannot get out of the info screen unless clicking on
some button as the 'add instance' (or a respective button in another view, as the 'add network
offering', 'add' a template, ...).
   
   ![image](https://user-images.githubusercontent.com/5025148/38833088-e91593de-419a-11e8-8a6d-33f2ad289e11.png)
   
   (ii) 'Add network offering' button on Home > Service Offerings - Network Offerings:
in this case, the add network offering view requires a scroll down from the user.
   
   ![image](https://user-images.githubusercontent.com/5025148/38833181-2fbe754e-419b-11e8-98b4-cbdb2ae25869.png)
   
   It should be something like the 'Add compute offering':
   ![image](https://user-images.githubusercontent.com/5025148/38833485-0eb45eda-419c-11e8-9ac5-687d46f8be1e.png)
   
   Thanks for the PR @rafaelweingartner . So far these are the points that I could raise in
my test environment.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message