cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] DaanHoogland opened a new pull request #2520: make Broadcast- and IsolationURI visible to admin
Date Mon, 02 Apr 2018 14:17:25 GMT
DaanHoogland opened a new pull request #2520: make Broadcast- and IsolationURI visible to admin
URL: https://github.com/apache/cloudstack/pull/2520
 
 
   ## Description
   As an admin /me wants to have easy access the broadcast uri ad the isolation uri used for
a nic. these fields were missing in the UI while available in the API.
   
   This can be argued to not be a bug, but it is a trivial fix of an old ommision, so feel
free to argue it should't go in 4.11.
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the boxes that
apply: -->
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [x] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   <img width="386" alt="normaluserview" src="https://user-images.githubusercontent.com/2486961/38199392-f81b398e-3690-11e8-94cb-6c2d3f6072cf.png">
   <img width="402" alt="adminuserview" src="https://user-images.githubusercontent.com/2486961/38199408-0193c5a8-3691-11e8-8505-6116c01115f6.png">
   
   ## How Has This Been Tested?
   tested this by creating a user in the simulator and let it create a VM. Next view the NICs
tab of the VM as normal user and as admin. The proof is in the screenshots.
   
   ## Checklist:
   <!--- Go over all the following points, and put an `x` in all the boxes that apply.
-->
   <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help!
-->
   - [ ] I have read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md)
document.
   - [x] My code follows the code style of this project.
   - [ ] My change requires a change to the documentation.
   - [ ] I have updated the documentation accordingly.
   - [ ] I have added tests to cover my changes.
   - [ ] All new and existing tests passed.
   
   <!-- The following will kick a packaging job, remove if as applicable -->
   @blueorangutan package
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message