From commits-return-73850-archive-asf-public=cust-asf.ponee.io@cloudstack.apache.org Thu Mar 29 13:58:39 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 35700180645 for ; Thu, 29 Mar 2018 13:58:39 +0200 (CEST) Received: (qmail 61243 invoked by uid 500); 29 Mar 2018 11:58:38 -0000 Mailing-List: contact commits-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list commits@cloudstack.apache.org Received: (qmail 61234 invoked by uid 99); 29 Mar 2018 11:58:38 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 29 Mar 2018 11:58:38 +0000 From: GitBox To: commits@cloudstack.apache.org Subject: [GitHub] rhtyd commented on a change in pull request #2505: CLOUDSTACK-10333: Secure Live VM Migration for KVM Message-ID: <152232471763.7767.1065983912935026489.gitbox@gitbox.apache.org> Date: Thu, 29 Mar 2018 11:58:37 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit rhtyd commented on a change in pull request #2505: CLOUDSTACK-10333: Secure Live VM Migration for KVM URL: https://github.com/apache/cloudstack/pull/2505#discussion_r178033101 ########## File path: agent/src/com/cloud/agent/Agent.java ########## @@ -274,6 +279,19 @@ public void start() { } } _shell.updateConnectedHost(); + + // In case of software based restart, GC to remove old instances + _executor.submit(new Runnable() { Review comment: Yes @rafaelweingartner, with the feature we've introduced a background thread that will perform software based restart of the agent. Look at the post renewal restart task. With this it will be easier to restart an agent without actually restarting the agent JVM process. This runnable is needed to GC old agent instance, we can remove this as well, but keeping it ensures that old agent is stopped+GC-ed. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services